Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query input should be resizable #248

Open
JohannesLichtenberger opened this issue Sep 30, 2020 · 3 comments
Open

Query input should be resizable #248

JohannesLichtenberger opened this issue Sep 30, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@JohannesLichtenberger
Copy link
Member

The query input field currently is too small for well formatted slightly longer queries. It thus should be resizable.

@tr1ms
Copy link

tr1ms commented Dec 30, 2020

Hello, I'm a beginner and I'd like to work on this, any insights?

@mosheduminer
Copy link
Member

mosheduminer commented Dec 30, 2020

Hi @gsonly, if you set up the dev environment and navigate to the Query route, you will see that there is a text box (with syntax highlighting) on top, an empty square on the bottom (that is where query results are shown) - and on the right there is a panel with recent and saved queries. We need to allow resizing the text box height, and when it is enlarged, the area below it needs to be shrunk smaller, and the text box is shrunk, we need to expand the area below.

I would suggest taking a look at the CSS resize attribute, and use svelte bindings to clientHeight to respond to box resize.

The height of the text box is defined in tailwind css (h-32) here, and the height of the results area is defined here.

Does that help? Do you have experience with svelte?

Please don't hesistate to ask for help. You can also find me on the SirixDB slack for more informal discussion.

@mosheduminer
Copy link
Member

@gsonly, how are things going?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants