Update to Debian 10 (Buster)

[celskeggs]

We're currently built around Stretch. It shouldn't be too hard to upgrade to Buster. Stretch isn't EOL yet, but it will be at some point, and we'll get nice shiny newer versions of things on Buster.

Elements of this:

• Upgrade build chroot to buster
• Upgrade container images to buster
• Upgrade deploy chroot to buster
• Upgrade installation CD to buster

[celskeggs]

Turns out that there's a bug in debootstrap on buster, where you can't specify --foreign and --unpack-tarball together, because the shell script is written wrong.

Patch to fix it:

--- /usr/share/debootstrap/functions	2019-12-15 14:20:12.689000000 -0500
+++ /usr/share/debootstrap/functions	2019-12-15 14:20:27.872000000 -0500
@@ -262,8 +262,8 @@
 
 ########################################################### option handling
 check_conflicting_option () {
-	if [ "$set_what_to_do" = --foreign ] && [ "${1%%=*}" = --unpack-tarball ] || \
-	   [ "${set_what_to_do%%=*}" = "--unpack-tarball" ] && [ "$1" == --foreign ]; then
+	if ( [ "$set_what_to_do" = --foreign ] && [ "${1%%=*}" = --unpack-tarball ] ) || \
+	   ( [ "${set_what_to_do%%=*}" = "--unpack-tarball" ] && [ "$1" = --foreign ] ); then
 		LOOSEN_CONFLICTING_RESTRICTION="true"
 	elif [ -n "$set_what_to_do" ]; then
 		error 1 ARG_CONFLICTING "$set_what_to_do is specified with $1, please use only one of those options."

They used == instead of = and got order-of-operations wrong.

[celskeggs]

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=946783