Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubernetes version info #105

Closed
celskeggs opened this issue Oct 7, 2017 · 2 comments
Closed

Fix kubernetes version info #105

celskeggs opened this issue Oct 7, 2017 · 2 comments

Comments

@celskeggs
Copy link
Member

celskeggs commented Oct 7, 2017

Currently, nodes are labeled with the version v1.8.0+$Format:%h$. This is ... wrong. We should fix this in the hyperkube build process.

@celskeggs
Copy link
Member Author

celskeggs commented Jan 22, 2018

This is normally replaced by certain changes being made during the git archive process. Key word: export-subst. We'll need to re-export the upstream tarball, probably, and figure out what we need to do to consistently have the export work correctly.

@celskeggs celskeggs self-assigned this Jan 24, 2018
@celskeggs
Copy link
Member Author

celskeggs commented Jan 24, 2018

This interpretation appears to be correct, and this bug has been fixed as of #229.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant