Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify matcher entries #13

Open
dehnert opened this issue Jan 26, 2013 · 1 comment
Open

Simplify matcher entries #13

dehnert opened this issue Jan 26, 2013 · 1 comment

Comments

@dehnert
Copy link
Member

dehnert commented Jan 26, 2013

Matcher entries currently look like (fetcher, matchers, cond). However, the matchers is always [build_matcher(regexp, re.I)], and the cond is always lambda m: True or lambda m: cls in m.cls. This should just be (fetcher, regexp, cond) or so to allow for more useful introspection of the matchers. (See also #4, which this is basically part of, and #11, which this is probably a prereq for.)

@dehnert
Copy link
Member Author

dehnert commented Jan 27, 2013

At the API level this is done by commit 64e9358. MatchEngine's internal storage format could be improved, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant