Warning is output with Node.js 14

[fu-sen]

I updated to the new version of Node.js 14.0.0, which was recently published.
Then surge will always return the following output:

(node:8280) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)

Of these, 8280 is random. the operation of surge CLI itself works.

[sintaxi]

Thanks for reporting. We'll look into it!

[fu-sen]

Node.js has been updated to 14.1.0. This issue continues.
(I use Windows 10 PowerShell)

> surge --version

   v0.21.3

(node:6752) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
(Use `node --trace-warnings ...` to show where the warning was created)

[jfarmer]

For anyone reading this, the underlying issue is with the https://github.com/winstonjs/winston logging library. See winstonjs/winston#1797

The message is the result of new error logging added in Node 14 (nodejs/node#29935).

[sintaxi]

@jfarmer thank you for the info. It helps a lot.

[syabro]

@sintaxi whinston fix winstonjs/winston#1800 was merged a while ago
Could you update deps?

[syabro]

Hmm, looks like prompt is not maintained anymore.
I think the best solution here is to switch to https://www.npmjs.com/package/prompts or https://www.npmjs.com/package/enquirer

[sintaxi]

@syabro thanks. What do you suppose is the easiest solution for taking care of the warning?

[syabro]

@sintaxi actually AFAIS prompt is being imported only

surge/lib/middleware/util/helpers.js

Line 1 in 86f3b43

var prompt = require('prompt')

But moreover it's not being used.
So I think you can just remove it.

[syabro]

Also I would strongly recommend to add eslint with https://eslint.org/docs/rules/no-unused-vars

[sintaxi]

Thanks for doing the heavy lifting @syabro.

I just released [email protected] which removes prompt which should resolve these CLI issues on [email protected].

[fu-sen]

I ran npm i -g surge and saw this improvement. Thank you for the improvement! 😄

[sintaxi]

@fu-sen you're welcome!