From 181a03030b133e63cc06f3335dbbe856ab6e216b Mon Sep 17 00:00:00 2001 From: Maximilian Antoni Date: Tue, 21 Jan 2020 10:44:11 +0100 Subject: [PATCH 1/3] Add module caching to GitHub action --- .github/workflows/main.yml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7f8965d0b..867cc2ff3 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -16,6 +16,14 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} + - name: Cache modules + uses: actions/cache@v1 + with: + path: ~/.npm + key: ${{ runner.OS }}-node-${{ hashFiles('package-lock.json') }} + restore-keys: | + ${{ runner.OS }}-node- + ${{ runner.OS }}- - run: npm ci - name: Pre-Test run: | From d86321ed05300c4def5233c658780fb41a13258a Mon Sep 17 00:00:00 2001 From: Maximilian Antoni Date: Tue, 21 Jan 2020 10:46:15 +0100 Subject: [PATCH 2/3] Skip Chromium download in GitHub action --- .github/workflows/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 867cc2ff3..6cd9f858e 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -25,6 +25,8 @@ jobs: ${{ runner.OS }}-node- ${{ runner.OS }}- - run: npm ci + env: + PUPPETEER_SKIP_CHROMIUM_DOWNLOAD: 1 - name: Pre-Test run: | npm run lint From 78c96e5cd2dbd9d648c414aa3a7a178f66970fd9 Mon Sep 17 00:00:00 2001 From: Maximilian Antoni Date: Tue, 21 Jan 2020 13:38:57 +0100 Subject: [PATCH 3/3] Set SINON_CHROME_BIN for esm-bundle test --- .github/workflows/main.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 6cd9f858e..e15465488 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -31,8 +31,9 @@ jobs: run: | npm run lint - npm run test-headless -- --chrome $(which google-chrome-stable) --allow-chrome-as-root - npm run test-webworker -- --chrome $(which google-chrome-stable) --allow-chrome-as-root + export SINON_CHROME_BIN=$(which google-chrome-stable) + npm run test-headless -- --chrome $SINON_CHROME_BIN --allow-chrome-as-root + npm run test-webworker -- --chrome $SINON_CHROME_BIN --allow-chrome-as-root npm run test-esm-bundle if: matrix.node-version == 10