Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing reload icon after adding an override #57

Closed
bradydowling opened this issue Jun 22, 2021 · 6 comments
Closed

Confusing reload icon after adding an override #57

bradydowling opened this issue Jun 22, 2021 · 6 comments

Comments

@bradydowling
Copy link

Screen Shot 2021-06-22 at 9 38 50 AM

This refresh icon is kinda confusing. It shows up only after you’ve changed an import map, which is also the exact time you’d want to refresh the page, which is generally what this icon means, but not here 😁

It could be helpful to have an actual icon that reloads the page. But it would mainly be helpful to change this icon to something different (e.g. ⚙️) or just remove it entirely.

@joeldenning
Copy link
Member

This refresh icon is kinda confusing. It shows up only after you’ve changed an import map, which is also the exact time you’d want to refresh the page, which is generally what this icon means, but not here

It's unclear which situation you're talking about - are you referring to overrides automatically applied for libraries like react when using the dev-libs option (to use react.development.js instead of react.production.min.js)? If so, then the page does need a refresh for those overrides to be applied.

@bradydowling
Copy link
Author

No. I'm talking about regular old import map overrides for an import map you've specified to localhost for example.

the page does need a refresh for those overrides to be applied.

I fully understand that. And this is exactly what makes the UX confusing.

To reproduce:

  1. Apply an override for an import map
  2. The page refresh icon appears next to the Inline Override text but clicking it does not refresh the page, instead it opens the edit modal

@joeldenning
Copy link
Member

I see, yeah I'm open to the reload icon becoming a button that reloads the page. Do you have interest in submitting a pull request implementing this?

@bradydowling
Copy link
Author

bradydowling commented Jun 22, 2021 via email

@bradydowling
Copy link
Author

Sorry, just being realistic here, I won't be able to get to this in the near future so don't wait for me to implement this if you or anyone else finds time for this.

@joeldenning
Copy link
Member

I had some time today so I implemented this in e00d6d9 and released it in https://github.com/joeldenning/import-map-overrides/releases/tag/v2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants