-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confusing reload icon after adding an override #57
Comments
It's unclear which situation you're talking about - are you referring to overrides automatically applied for libraries like |
No. I'm talking about regular old import map overrides for an import map you've specified to localhost for example.
I fully understand that. And this is exactly what makes the UX confusing. To reproduce:
|
I see, yeah I'm open to the reload icon becoming a button that reloads the page. Do you have interest in submitting a pull request implementing this? |
Ya sure, I can look into it. I’ll let you know if I have a PR or if I just get too busy for it.
… On Jun 22, 2021, at 5:39 PM, Joel Denning ***@***.***> wrote:
I see, yeah I'm open to the reload icon becoming a button that reloads the page. Do you have interest in submitting a pull request implementing this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sorry, just being realistic here, I won't be able to get to this in the near future so don't wait for me to implement this if you or anyone else finds time for this. |
I had some time today so I implemented this in e00d6d9 and released it in https://github.com/joeldenning/import-map-overrides/releases/tag/v2.4.0 |
This refresh icon is kinda confusing. It shows up only after you’ve changed an import map, which is also the exact time you’d want to refresh the page, which is generally what this icon means, but not here 😁
It could be helpful to have an actual icon that reloads the page. But it would mainly be helpful to change this icon to something different (e.g. ⚙️) or just remove it entirely.
The text was updated successfully, but these errors were encountered: