[python] Update add_new_collection method to support Scene collections
#3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-dark
force-pushed
the
dark/add_new_scene
branch
from
a8a4b49 to
f58a030
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3491 +/- ##
==========================================
+ Coverage 86.27% 86.32% +0.04%
==========================================
Files 55 55
Lines 6338 6338
==========================================
+ Hits 5468 5471 +3
+ Misses 870 867 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
approved these changes
Dec 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
…tions (#3491) * Add kwargs to `add_new_collection` for adding `Scene` objects * Use `add_new_collection` for creating scenes in tests
johnkerl
pushed a commit
that referenced
this pull request
Dec 20, 2024
…tions (#3491) (#3499) * Add kwargs to `add_new_collection` for adding `Scene` objects * Use `add_new_collection` for creating scenes in tests Co-authored-by: Julia Dark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kwargstoadd_new_collectionso the full API forScene.createcan be supported.add_new_collectionfor creating aSceneinside thespatialcollection.