[c++] Match zero-basing for old/new sparse-array shapes #3439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: As pointed out by @XanthosXanthopoulos .
Changes:
This makes the zero-basing logic the same for both old-style and new-style (pre-1.15 and post-1.15) sparse arrays the same.
It also renames some methods which had names that did not well reflect their purposes.
No unit tests are changed, so all passes still: this mod is a no-op for all non-spatial data since those all have soma domain/maxdomain (core current domain/domain) starting at 0. However, this helps clear the path for further development on other arrays which may have their domain/maxdomain not starting at zero.
Notes for Reviewer: