Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Match zero-basing for old/new sparse-array shapes #3439

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Dec 13, 2024

Issue and/or context: As pointed out by @XanthosXanthopoulos .

Changes:

This makes the zero-basing logic the same for both old-style and new-style (pre-1.15 and post-1.15) sparse arrays the same.

It also renames some methods which had names that did not well reflect their purposes.

No unit tests are changed, so all passes still: this mod is a no-op for all non-spatial data since those all have soma domain/maxdomain (core current domain/domain) starting at 0. However, this helps clear the path for further development on other arrays which may have their domain/maxdomain not starting at zero.

Notes for Reviewer:

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.27%. Comparing base (e8ef0ac) to head (38ba1c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3439      +/-   ##
==========================================
+ Coverage   86.22%   86.27%   +0.04%     
==========================================
  Files          55       55              
  Lines        6295     6295              
==========================================
+ Hits         5428     5431       +3     
+ Misses        867      864       -3     
Flag Coverage Δ
python 86.27% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 86.27% <ø> (+0.04%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 8eed6dc into main Dec 14, 2024
16 checks passed
@johnkerl johnkerl deleted the kerl/shapes-zero-based branch December 14, 2024 01:05
johnkerl added a commit that referenced this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants