From 6134ec74a041d03399fde89d600648c615a7fed0 Mon Sep 17 00:00:00 2001 From: Ryan Williams Date: Mon, 28 Oct 2024 10:01:04 -0400 Subject: [PATCH] pin typeguard@afad2c7 https://github.com/agronholm/typeguard/pull/496 caused CI to fail on Python 3.9, e.g. https://github.com/single-cell-data/TileDB-SOMA/actions/runs/11522767244/job/32157898699 --- apis/python/requirements_dev.txt | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/apis/python/requirements_dev.txt b/apis/python/requirements_dev.txt index 7e1fe8532a..16211e94c7 100644 --- a/apis/python/requirements_dev.txt +++ b/apis/python/requirements_dev.txt @@ -3,8 +3,9 @@ ruff pytest pytest-cov sparse -# Python 3.12 support requires https://github.com/agronholm/typeguard/pull/490; -# use Typeguard @ HEAD until that PR is included in a release. See also: -# https://github.com/single-cell-data/TileDB-SOMA/issues/3216 -typeguard @ git+https://github.com/agronholm/typeguard +# Python 3.12 support requires https://github.com/agronholm/typeguard/pull/490, which landed between 4.3.0 and 4.4.0. +# However, 4.4.0 also included https://github.com/agronholm/typeguard/pull/496, which causes errors in Python 3.9 (e.g. +# https://github.com/single-cell-data/TileDB-SOMA/actions/runs/11545217103/job/32131849817), so we are pinning to the +# last useful commit here. See also: https://github.com/single-cell-data/TileDB-SOMA/issues/3216. +typeguard @ git+https://github.com/agronholm/typeguard@afad2c7 types-setuptools