Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Support negative and string indices for DataFrame #933

Closed
Tracked by #738
thetorpedodog opened this issue Feb 14, 2023 · 0 comments · Fixed by #948
Closed
Tracked by #738

[Bug] Support negative and string indices for DataFrame #933

thetorpedodog opened this issue Feb 14, 2023 · 0 comments · Fixed by #948
Assignees
Labels
bug Something isn't working

Comments

@thetorpedodog
Copy link
Contributor

Accessing a negative index of a dataframe currently causes an error. Per single-cell-data/SOMA#121 (comment) it should not (only when the domain is non-negative).

if lo < 0 or hi < 0:
raise ValueError(
f"slice start and stop may not be negative; got ({lo}, {hi})"
)

@thetorpedodog thetorpedodog added the bug Something isn't working label Feb 14, 2023
@thetorpedodog thetorpedodog self-assigned this Feb 14, 2023
@atolopko-czi atolopko-czi mentioned this issue Feb 14, 2023
5 tasks
@johnkerl johnkerl changed the title [Bug] Support negative and string indices to DataFrames. [Bug] Support negative and string indices to DataFrames Feb 14, 2023
@johnkerl johnkerl changed the title [Bug] Support negative and string indices to DataFrames [Bug] Support negative and string indices for DataFrame Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant