Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Revisit numba 0.58 dependency #1733

Closed
johnkerl opened this issue Sep 28, 2023 · 5 comments
Closed

[python] Revisit numba 0.58 dependency #1733

johnkerl opened this issue Sep 28, 2023 · 5 comments
Assignees
Labels

Comments

@johnkerl
Copy link
Member

This was updated in #1723 (and release-1.5 branch #1726).

Meanwhile I ran a condability check -- which in hindsight I should have run before accepting #1723 -- at TileDB-Inc/tiledbsoma-feedstock#48.

This failed as noted by @jdblischak at TileDB-Inc/tiledbsoma-feedstock#48 (comment) since numba 0.58.0 is not yet available on conda-forge

numba 0.58.0 isn't available on conda-forge yet

We may need to revert our dependency back to numba 0.57 until numba 0.58.0 is available at conda-forge.

cc @thetorpedodog @mlin @jdblischak

@jdblischak
Copy link
Collaborator

Quick update: Progress is being made (conda-forge/numba-feedstock#126 (comment)), but still no numba 0.58.x available from conda-forge

@jdblischak
Copy link
Collaborator

Numba 0.58.1 was merged this morning for conda-forge (conda-forge/numba-feedstock#128, conda-forge/numba-feedstock@172c489)

@johnkerl
Copy link
Member Author

TileDB-Inc/tiledbsoma-feedstock#48 resolves this issue -- the moment we drop support for Python 3.7 (#1790), which is imminent. Leaving this open until then.

@bkmartinjr
Copy link
Member

@johnkerl - what (if any) is the action to be taken? Or is this resolved? My understanding is that with the new >=0.58 pin, both conda and pypi backed installs should be fine, as 0.58 is available (in both locations). Closing, but please re-open if I misunderstand the issue.

@johnkerl
Copy link
Member Author

Sorry @bkmartinjr I forgot to signal my intent -- yes, #2122 resolves this, and I wanted to honor/acknowledge your contribution on that front. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants