-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
267 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,125 @@ | ||
# Confirm shared object copying when building the Python package | ||
# https://github.com/single-cell-data/TileDB-SOMA/pull/1937 | ||
|
||
name: Python SO copying | ||
|
||
on: | ||
push: | ||
paths: | ||
- '.github/workflows/python-so-copying.yml' | ||
- 'apis/python/**' | ||
- 'libtiledbsoma/cmake/**' | ||
pull_request: | ||
paths: | ||
- '.github/workflows/python-so-copying.yml' | ||
- 'apis/python/**' | ||
- 'libtiledbsoma/cmake/**' | ||
workflow_dispatch: | ||
|
||
defaults: | ||
run: | ||
shell: bash | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
name: "TILEDB_EXISTS: ${{ matrix.TILEDB_EXISTS }} TILEDBSOMA_EXISTS: ${{ matrix.TILEDBSOMA_EXISTS }}" | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
TILEDB_EXISTS: ["no", "yes"] | ||
TILEDBSOMA_EXISTS: ["no", "yes"] | ||
exclude: | ||
- TILEDB_EXISTS: "no" | ||
TILEDBSOMA_EXISTS: "yes" | ||
container: | ||
image: ubuntu:22.04 | ||
steps: | ||
- name: Docker image info | ||
run: | | ||
uname -a | ||
cat /etc/lsb-release | ||
- name: Setup | ||
run: | | ||
apt-get update | ||
apt-get install --yes cmake git python-is-python3 python3 python3-pip python3-venv unzip wget | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 # for setuptools-scm | ||
- name: Configure Git | ||
run: | | ||
# This is a permissions quirk due to running Git as root inside of a Docker container | ||
git config --global --add safe.directory $(pwd) | ||
git branch | ||
- name: Install pre-built libtiledb | ||
if: ${{ matrix.TILEDB_EXISTS == 'yes' }} | ||
run: | | ||
mkdir -p external | ||
wget --quiet https://github.com/TileDB-Inc/TileDB/releases/download/2.19.1/tiledb-linux-x86_64-2.19.1-29ceb3e7.tar.gz | ||
tar -C external -xzf tiledb-linux-x86_64-*.tar.gz | ||
ls external/lib/ | ||
echo "LD_LIBRARY_PATH=$(pwd)/external/lib" >> $GITHUB_ENV | ||
echo "PKG_CONFIG_PATH=$(pwd)/external/lib/pkgconfig" >> $GITHUB_ENV | ||
echo "TILEDB_PATH=$(pwd)/external" >> $GITHUB_ENV | ||
- name: Build and install libtiledbsoma | ||
if: ${{ matrix.TILEDBSOMA_EXISTS == 'yes' }} | ||
run: | | ||
cmake -S libtiledbsoma -B build-libtiledbsoma \ | ||
-D CMAKE_BUILD_TYPE=Release \ | ||
-D CMAKE_PREFIX_PATH=$(pwd)/external/ \ | ||
-D CMAKE_INSTALL_PREFIX:PATH=$(pwd)/external/ \ | ||
-D OVERRIDE_INSTALL_PREFIX=OFF \ | ||
-D DOWNLOAD_TILEDB_PREBUILT=OFF \ | ||
-D FORCE_BUILD_TILEDB=OFF | ||
cmake --build build-libtiledbsoma -j $(nproc) | ||
cmake --build build-libtiledbsoma --target install-libtiledbsoma | ||
ls external/lib/ | ||
echo "TILEDBSOMA_PATH=$(pwd)/external" >> $GITHUB_ENV | ||
- name: Setup Python | ||
run: | | ||
python --version | ||
python -m venv ./venv-soma | ||
./venv-soma/bin/python -m pip install --prefer-binary pybind11-global typeguard sparse wheel | ||
./venv-soma/bin/python -m pip list | ||
- name: Build wheel | ||
run: | | ||
echo env vars: $LD_LIBRARY_PATH $PKG_CONFIG_PATH $TILEDB_PATH $TILEDBSOMA_PATH | ||
cd apis/python | ||
../../venv-soma/bin/python setup.py bdist_wheel | ||
- name: Inspect wheel | ||
run: unzip -l apis/python/dist/tiledbsoma-*.whl | grep '\.so' | ||
- name: Confirm libtiledb.so is copied | ||
if: ${{ matrix.TILEDB_EXISTS == 'no' }} | ||
run: unzip -l apis/python/dist/tiledbsoma-*.whl | grep -q libtiledb.so | ||
- name: Confirm libtiledb.so is **not** copied when using external shared object | ||
if: ${{ matrix.TILEDB_EXISTS == 'yes' }} | ||
run: | | ||
if unzip -l apis/python/dist/tiledbsoma-*.whl | grep -q libtiledb.so | ||
then | ||
echo "libtiledb.so was copied into the wheel when it was built against an external shared object" | ||
exit 1 | ||
fi | ||
- name: Confirm libtiledbsoma.so is copied | ||
if: ${{ matrix.TILEDBSOMA_EXISTS == 'no' }} | ||
run: unzip -l apis/python/dist/tiledbsoma-*.whl | grep -q libtiledbsoma.so | ||
- name: Confirm libtiledbsoma.so is **not** copied when using external shared object | ||
if: ${{ matrix.TILEDBSOMA_EXISTS == 'yes' }} | ||
run: | | ||
if unzip -l apis/python/dist/tiledbsoma-*.whl | grep -q libtiledbsoma.so | ||
then | ||
echo "libtiledbsoma.so was copied into the wheel when it was built against an external shared object" | ||
exit 1 | ||
fi | ||
- name: Install wheel | ||
run: ./venv-soma/bin/python -m pip install --prefer-binary apis/python/dist/tiledbsoma-*.whl | ||
- name: Check linking and RPATH | ||
run: | | ||
ldd ./venv-soma/lib/python*/site-packages/tiledbsoma/pytiledbsoma.*.so | ||
readelf -d ./venv-soma/lib/python*/site-packages/tiledbsoma/pytiledbsoma.*.so | grep R*PATH | ||
- name: Runtime test | ||
run: ./venv-soma/bin/python -c "import tiledbsoma; print(tiledbsoma.pytiledbsoma.version())" | ||
- name: Confirm linking to installed shared objects | ||
run: | | ||
rm -fr build/ build-libtiledbsoma/ dist/ apis/python/build apis/python/src/tiledbsoma/*tile*.so* | ||
find . -name '*tile*.so*' # should only show shared objects installed in virtual env | ||
./venv-soma/bin/python -c "import tiledbsoma; print(tiledbsoma.pytiledbsoma.version())" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/** | ||
* @file soma_dense_ndarray.cc | ||
* | ||
* @section LICENSE | ||
* | ||
* The MIT License | ||
* | ||
* @copyright Copyright (c) 2024 TileDB, Inc. | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
* THE SOFTWARE. | ||
* | ||
* @section DESCRIPTION | ||
* | ||
* This file defines the SOMADenseNDArray bindings. | ||
*/ | ||
|
||
#include <pybind11/numpy.h> | ||
#include <pybind11/pybind11.h> | ||
#include <pybind11/pytypes.h> | ||
#include <pybind11/stl.h> | ||
#include <pybind11/stl_bind.h> | ||
|
||
#include <tiledbsoma/tiledbsoma> | ||
|
||
#include "common.h" | ||
|
||
namespace libtiledbsomacpp { | ||
|
||
namespace py = pybind11; | ||
using namespace py::literals; | ||
using namespace tiledbsoma; | ||
|
||
void load_soma_dense_ndarray(py::module &m) { | ||
py::class_<SOMADenseNDArray, SOMAArray, SOMAObject>(m, "SOMADenseNDArray") | ||
|
||
.def_static( | ||
"open", | ||
py::overload_cast< | ||
std::string_view, | ||
OpenMode, | ||
std::map<std::string, std::string>, | ||
std::vector<std::string>, | ||
ResultOrder, | ||
std::optional<std::pair<uint64_t, uint64_t>>>(&SOMADenseNDArray::open), | ||
"uri"_a, | ||
"mode"_a, | ||
py::kw_only(), | ||
"platform_config"_a = py::dict(), | ||
"column_names"_a = py::none(), | ||
"result_order"_a = ResultOrder::automatic, | ||
"timestamp"_a = py::none()) | ||
|
||
.def_static("exists", &SOMADenseNDArray::exists); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/** | ||
* @file soma_sparse_ndarray.cc | ||
* | ||
* @section LICENSE | ||
* | ||
* The MIT License | ||
* | ||
* @copyright Copyright (c) 2024 TileDB, Inc. | ||
* | ||
* Permission is hereby granted, free of charge, to any person obtaining a copy | ||
* of this software and associated documentation files (the "Software"), to deal | ||
* in the Software without restriction, including without limitation the rights | ||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
* copies of the Software, and to permit persons to whom the Software is | ||
* furnished to do so, subject to the following conditions: | ||
* | ||
* The above copyright notice and this permission notice shall be included in | ||
* all copies or substantial portions of the Software. | ||
* | ||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
* THE SOFTWARE. | ||
* | ||
* @section DESCRIPTION | ||
* | ||
* This file defines the SOMASparseNDArray bindings. | ||
*/ | ||
|
||
#include <pybind11/numpy.h> | ||
#include <pybind11/pybind11.h> | ||
#include <pybind11/pytypes.h> | ||
#include <pybind11/stl.h> | ||
#include <pybind11/stl_bind.h> | ||
|
||
#include <tiledbsoma/tiledbsoma> | ||
|
||
#include "common.h" | ||
|
||
namespace libtiledbsomacpp { | ||
|
||
namespace py = pybind11; | ||
using namespace py::literals; | ||
using namespace tiledbsoma; | ||
|
||
void load_soma_sparse_ndarray(py::module &m) { | ||
py::class_<SOMASparseNDArray, SOMAArray, SOMAObject>(m, "SOMASparseNDArray") | ||
|
||
.def_static( | ||
"open", | ||
py::overload_cast< | ||
std::string_view, | ||
OpenMode, | ||
std::map<std::string, std::string>, | ||
std::vector<std::string>, | ||
ResultOrder, | ||
std::optional<std::pair<uint64_t, uint64_t>>>(&SOMASparseNDArray::open), | ||
"uri"_a, | ||
"mode"_a, | ||
py::kw_only(), | ||
"platform_config"_a = py::dict(), | ||
"column_names"_a = py::none(), | ||
"result_order"_a = ResultOrder::automatic, | ||
"timestamp"_a = py::none()) | ||
|
||
.def_static("exists", &SOMASparseNDArray::exists); | ||
} | ||
} |