From 097e439f8d67550f7ae8cc77c8d39e85e446b9d0 Mon Sep 17 00:00:00 2001 From: John Kerl Date: Mon, 2 Oct 2023 16:57:02 -0400 Subject: [PATCH] code-review feedback --- apis/python/src/tiledbsoma/_dataframe.py | 3 ++- apis/python/tests/test_dataframe.py | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apis/python/src/tiledbsoma/_dataframe.py b/apis/python/src/tiledbsoma/_dataframe.py index d112c58bc6..fef2f992a6 100644 --- a/apis/python/src/tiledbsoma/_dataframe.py +++ b/apis/python/src/tiledbsoma/_dataframe.py @@ -391,7 +391,8 @@ def write( If a column is of categorical type in the schema and a flattened/non-categorical column is presented for data on write, a ``ValueError`` is raised. If a column is of non-categorical type in the schema and a categorical column is presented for data - on write, the data are auto-flattened on behalf of the user. + on write, the data are written as an array of category values, and the category-type + information is not saved. Raises: TypeError: diff --git a/apis/python/tests/test_dataframe.py b/apis/python/tests/test_dataframe.py index b0ee2848ac..9c05a18ede 100644 --- a/apis/python/tests/test_dataframe.py +++ b/apis/python/tests/test_dataframe.py @@ -122,8 +122,7 @@ def test_dataframe_with_float_dim(tmp_path, arrow_schema): assert sdf.index_column_names == ("bar",) -@pytest.mark.parametrize("downgrade", [False, True]) -def test_dataframe_with_enumeration(tmp_path, downgrade): +def test_dataframe_with_enumeration(tmp_path): schema = pa.schema( [ pa.field("foo", pa.dictionary(pa.int64(), pa.large_string())),