Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paste context menu not dismissed #2153

Open
1 task done
AtlasAutocode opened this issue Aug 26, 2024 · 8 comments
Open
1 task done

Paste context menu not dismissed #2153

AtlasAutocode opened this issue Aug 26, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@AtlasAutocode
Copy link
Collaborator

Is there an existing issue for this?

Flutter Quill version

10.4.4

Steps to reproduce

Use the example app and run on mobile.
Long press to select a word, get popup menu and select Copy. Popup menu is dismissed.
Long press at a different place, get popup menu and select Paste. Text is pasted but the popup menu is NOT dismissed.

This issue was fixed in PR2116
These changes were removed in PR2128 to address the problem with the magnifier.

Expected results

Popup menu should be dismissed after paste is selected.

Actual results

Popup menu is still present after paste is selected.

Code sample

Code sample
[Paste your code here]

Additional Context

Screenshots / Video demonstration

[Upload media here]

Logs
[Paste your logs here]
@AtlasAutocode AtlasAutocode added the bug Something isn't working label Aug 26, 2024
@AtlasAutocode
Copy link
Collaborator Author

@demoYang and @CatHood0 can you take a look at this problem?
These changes appear to be mutually exclusive.
I regret that I do not understand mobile enough to be able to figure out what is going on.

@CatHood0
Copy link
Collaborator

CatHood0 commented Aug 26, 2024

I know what part is causing the error. I'll test my fix soon (i don't know why it was removed)

@AtlasAutocode
Copy link
Collaborator Author

@CatHood0 your changes fixed the paste problem.
I assume @demoYang made the changes because it was needed to fix the problem with the magnifier.

However, when I re-introduced your changes, it caused even more problems.
So, I think there is some deeper conflict between paste popup and magnifier.

@CatHood0
Copy link
Collaborator

However, when I re-introduced your changes, it caused even more problems.

I don't expect that. It's weird. You have a point, it could be something more deeper than we expect.

@CatHood0
Copy link
Collaborator

Does this issue still persists? If not we need to close it.

@EchoEllet
Copy link
Collaborator

@AtlasAutocode

Is this still an issue?

@AtlasAutocode
Copy link
Collaborator Author

Yes, still exists.
I haven't had time to look into it since I almost never use mobile and know nothing about how such popups are managed.
It's an obvious bug but not critical. Feel free to close this issue.

@EchoEllet
Copy link
Collaborator

Will keep it open, since we don't add new features anymore, we should have more time but for now, we're focusing on other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants
@EchoEllet @CatHood0 @AtlasAutocode and others