Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gocardless pr #9

Merged
merged 24 commits into from
Jul 14, 2020
Merged

Gocardless pr #9

merged 24 commits into from
Jul 14, 2020

Conversation

jacobrobertbaca
Copy link

This branch is a local copy of the gocardless/master branch

andrewrjones and others added 24 commits May 11, 2020 16:47
Run on Circle without private Docker image
By default, we will still get private channels. This requires the extra
`groups:` scopes.

Previously, even if we didn't want to sync private groups, the calls to
the Slack API would fail as the calls we made defined the types as
`"public_channel,private_channel"`.

There is now an optional config, `private_channels`, that allows the
user to disable private channels in the config file.

Also added documentation for the config file.
Allow user to disable private channels
Allow user to specify specific channels
- Files
- Remote Files
- Threads
- User Groups
- Teams

Updated Streams:
- Channels
- Channel Members
- Messages

* Adopted a parent/child stream relationship for Messages and Threads.
* Added bookmarking for all Incremental Streams.
* Added basic tap tester framework
* Changed circle yml to reflect tap tester framework
* More documentation
* Public Channel Auto-Join now only joins channels that are specified if a channel list is provided via the config.
Copy link

@asaf-erlich asaf-erlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we might just need to communicate to the PR owner that we had to make fixes and merged in their commits on top of ours. I would strongly encourage you to merge it in and NOT squash commits so the original author still keeps his commits intact.

@jacobrobertbaca jacobrobertbaca merged commit d672fed into master Jul 14, 2020
@jacobrobertbaca jacobrobertbaca deleted the gocardless-pr branch July 14, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants