Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to disable private channels #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andrewrjones
Copy link

Description of change

Previously, even if we didn't want to sync private groups, the calls to
the Slack API would fail as the calls we made defined the types as
"public_channel,private_channel".

There is now an optional config, private_channels, that allows the
user to disable private channels in the config file.

By default, we will still get private channels. This requires the extra
groups: scopes.

Also added documentation for the config file.

Manual QA steps

  • Run the tap without any additional config and it should perform as it did previously

  • Run the tap with "private_channels":true and it should perform as it did previously

  • Run the tap with "private_channels":false and it will now only sync public channels

  • Run the tap without any additional config and with a Slack account that does not have the group: permissions and it will fail with the following:

slack.errors.SlackApiError: The request to the Slack API failed.
The server responded with: {'ok': False, 'error': 'missing_scope', 'needed': 'groups:read', 'provided': 'channels:history,channels:read,users:read'}
  • Run the tap with the same Slack account and with "private_channels":false and it will now only sync public channels and not fail with an error

Risks

  • No test coverage

Rollback steps

  • revert this branch

By default, we will still get private channels. This requires the extra
`groups:` scopes.

Previously, even if we didn't want to sync private groups, the calls to
the Slack API would fail as the calls we made defined the types as
`"public_channel,private_channel"`.

There is now an optional config, `private_channels`, that allows the
user to disable private channels in the config file.

Also added documentation for the config file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant