Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_email_confirmed to users #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GJmelody
Copy link

Description of change

Add field is_email_confirmed to schema users. It indicates whether an invited user has accepted invitation and joined workspace

Sample slack API response
{
"id":"*********",
"name":"dummy_name",
"deleted":false,
"color":"757575",
"real_name":"dummy_name",
"tz":"America/Los_Angeles",
"tz_label":"Pacific Standard Time",
"tz_offset":-28800,
"profile":{},
"is_admin":false,
"is_owner":false,
"is_primary_owner":false,
"is_restricted":false,
"is_ultra_restricted":false,
"is_bot":false,
"is_app_user":false,
"updated":0,
"is_email_confirmed":false,
"who_can_share_contact_card":"EVERYONE"
}

Manual QA steps

N/A (not sure how to test)

Risks

This field maybe missing from certain API responses depending on the context of each Slack workspace

Rollback steps

  • revert this branch

@cmerrick
Copy link

Hi @GJmelody, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

@cmerrick
Copy link

You did it @GJmelody!

Thank you for signing the Singer Contribution License Agreement.

@GJmelody
Copy link
Author

@dwallace0723 could you help take a look at this PR? thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants