Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tap does not handle invoice/estimate_messages and invoice payments correctly #35

Open
kspeer825 opened this issue Dec 3, 2019 · 0 comments

Comments

@kspeer825
Copy link
Contributor

kspeer825 commented Dec 3, 2019

Expected: We expect the tap to capture estimate messages for every estimate.

Actual: When creating multiple estimate messages prior to a sync job the tap only sends a record for the last created estimate message. So, if multiple estimates are acted on e.g. sent, declined, approved, the tap will only capture the action that occurred last.

To reproduce: Create a message in Estimate A by marking it as accepted. Then create two messages in Estimate B by marking it as accepted and then sent. The expectation is unclear whether only the last message should be sent for each estimate or if all messages should be sent for each estimate. Regardless, the tap should capture more than just the last created message.

This defect is true for the following streams:
invoice_messages
invoice_payments

@kspeer825 kspeer825 changed the title tap does not handle estimate_messages correctly tap does not handle estimate_messages/invoice_messages correctly Dec 4, 2019
@kspeer825 kspeer825 changed the title tap does not handle estimate_messages/invoice_messages correctly tap does not handle invoice/estimate_messages and invoice payments correctly Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant