Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratelimit helper does not support multi-threading or async #115

Open
judahrand opened this issue Dec 15, 2019 · 0 comments
Open

Ratelimit helper does not support multi-threading or async #115

judahrand opened this issue Dec 15, 2019 · 0 comments

Comments

@judahrand
Copy link
Contributor

It seems to me that the ratelimiting helper function found in singer.utils.ratelimit is rather limited. Perhaps we should replace it with an implementation using this rather excellent package which does support multi threading. There was also a PR open which added support for async but for some reason it was closed (tomasbasham/ratelimit#35). Maybe if lack of maintenance is a concern the whole package should be forked and maintained as part of the Singer.io project? It seems like a universally useful package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant