Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlining Images on Windows #22

Open
xemoka opened this issue Jan 10, 2018 · 2 comments
Open

Inlining Images on Windows #22

xemoka opened this issue Jan 10, 2018 · 2 comments
Labels

Comments

@xemoka
Copy link
Contributor

xemoka commented Jan 10, 2018

Thank you for this project, it was exactly what I was looking for.

There appears to be a problem inlining Images on Windows though: it just doesn't, as if the --no-inline flag is set. Work fine on OSX. Is this just my setup or replicable?

Using Win7/Node8.9.4, tried with both npm and github installations.

@sinedied
Copy link
Owner

The project was mainly developed on OSX, so it's possible there's a few quirks on Windows 😕

I bet it's a path issue somewhere in the inlining code (was added in this PR: #16), if you want to take a look at it as I do not have a windows VM at hand for now.

@sinedied sinedied added the bug label Jan 11, 2018
@xemoka
Copy link
Contributor Author

xemoka commented Jan 11, 2018

Thanks, I'll try and take a closer look when I have a bit of time—honestly not sure how soon that'll be though, ha.

@xemoka xemoka changed the title inlining Images on Windows Inlining Images on Windows Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants