Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the latest spec #1

Closed
zcorpan opened this issue Aug 11, 2014 · 10 comments · Fixed by #6
Closed

Match the latest spec #1

zcorpan opened this issue Aug 11, 2014 · 10 comments · Fixed by #6
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@zcorpan
Copy link

zcorpan commented Aug 11, 2014

Issuehunt badges

  • h descriptor is not allowed anymore
  • w and x on the same candidate is not allowed
  • Just splitting on commas does not parse correctly (e.g. URLs can contain commas).

http://www.whatwg.org/specs/web-apps/current-work/multipage/embedded-content.html#parse-a-srcset-attribute


IssueHunt Summary

willianveiga willianveiga has been rewarded.

Backers (Total: $60.00)

Submitted pull Requests


Tips

@sindresorhus
Copy link
Owner

Thanks for letting me know. Would you be interested in doing a pull request? No worries if not. I'll get to it eventually then.

@mahnunchik
Copy link

Hi @zcorpan @sindresorhus

Do you plan to fix that? Or are there other solutions?

@zcorpan
Copy link
Author

zcorpan commented Jan 13, 2015

I do not plan to fix this. For the third point there is a conforming srcset parser impl at https://github.com/baloneysandwiches/parse-srcset/

@sindresorhus sindresorhus changed the title Does not match the spec Match the latest spec Sep 10, 2019
@issuehunt-oss
Copy link

issuehunt-oss bot commented Sep 11, 2019

@issuehunt has funded $60.00 to this issue.


@fisker
Copy link

fisker commented Nov 19, 2019

can I work on this

@alexander-akait
Copy link

@fisker Do you want to start working at that?

@fisker
Copy link

fisker commented Jan 23, 2020

@evilebottnawi #3 already started working on this, but have not fix the changes requested for long time.

@sindresorhus
Copy link
Owner

@fisker Go ahead :)

@fisker
Copy link

fisker commented Feb 27, 2020

After reading the spec, and I found that parse-srcset project do exactly the spec says. I don't think I can do better. So, I'm not going to work on this issue any more, unless we want the similar implementation. I feel I made a mistake replacing parse-srcset with srcset on prettier project.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Jul 12, 2020

@sindresorhus has rewarded $54.00 to @willianveiga. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $6.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants