Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use union merge for readme and CSS #23

Merged
merged 1 commit into from
Feb 18, 2016
Merged

Use union merge for readme and CSS #23

merged 1 commit into from
Feb 18, 2016

Conversation

hkdobrev
Copy link
Contributor

There are two lists-like sections in the readme:

  • Highlights
  • Related

When there are multiple pull requests adding to the lists whichever is merged first would cause conflicts in the rest.

The union merge cause Git to try to resolve the conflicts automatically by keeping both additions.

Read more here: https://about.gitlab.com/2015/02/10/gitlab-reduced-merge-conflicts-by-90-percent-with-changelog-placeholders/

I think this is also useful for the CSS file where it would be common separate rules to be added to the bottom in different pull requests.

There are two lists-like sections in the readme:
- Highlights
- Related

When there are multiple pull requests adding to the lists
whichever is merged first would cause conflicts in the rest.

The union merge cause Git to try to resolve the conflicts
automatically by keeping both additions.

Read more here: https://about.gitlab.com/2015/02/10/gitlab-reduced-merge-conflicts-by-90-percent-with-changelog-placeholders/

I think this is also useful for the CSS file where it would be common
separate rules to be added to the bottom in different pull requests.
@sindresorhus
Copy link
Member

👍 Too bad this will only work for manual merge and not through the GitHub UI...

sindresorhus added a commit that referenced this pull request Feb 18, 2016
Use union merge for readme and CSS
@sindresorhus sindresorhus merged commit e11f751 into refined-github:master Feb 18, 2016
@hkdobrev hkdobrev deleted the merge-union branch February 18, 2016 20:13
@hkdobrev
Copy link
Contributor Author

I've only recently learned about this use of .gitattributes and didn't know GitHub does not support it properly. Here's a conversation about it saying GitHub has added it to their feature requests list: isaacs/github#487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants