Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize retry backoff algorithm #389

Closed
xmedeko opened this issue Oct 25, 2021 · 1 comment · Fixed by #454
Closed

Customize retry backoff algorithm #389

xmedeko opened this issue Oct 25, 2021 · 1 comment · Fixed by #454
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@xmedeko
Copy link

xmedeko commented Oct 25, 2021 •
edited
Loading

Current backoff algorithm is 0.3 * (2 ** (retry - 1)) * 1000 that does not suit for all. E.g. I may like to change some coefficient or add a random jitter (see AWS Exponential Backoff And Jitter). Solution may be simple - just allow custom function to calculate the delay.
@xmedeko xmedeko changed the title Parametrize retry backoff algorithm Customize retry backoff algorithm Oct 26, 2021
@sindresorhus
Copy link
Owner

Yeah, we could add a retry.calculateDelay option. Pull request welcome.

Could be similar to https://github.com/sindresorhus/got/blob/f6d1fb71b5e107ef4a6e3b5d5dfa2a80ec3f30a5/documentation/7-retry.md#calculatedelay

@sindresorhus sindresorhus added enhancement New feature or request help wanted Extra attention is needed labels Oct 27, 2021
@fvanwijk fvanwijk mentioned this issue Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add retry.backoffLimit option fvanwijk/ky
2 participants
@sindresorhus @xmedeko