Hangs after returning status

[himanshumehta1114]

Bug

When I check the status for a URL that is behind VPN - which resolves DNS but does not return any response. is-reachable returns false as expected but it hangs after returning the status.

Actual behavior

is-reachable hangs after returning status.

Expected behavior

is-reachable should abort after returning status.

Debug findings

After some debug, I found that timeout is not respected by checkHttp function. pTimeout exits after the set timeout but got in checkHttp function continues to make the request. If the request gives no response, the request timeouts after a while and retries multiple times.

Solution

Currently is-reachable is using [email protected] which had some issues with timeout as described in got#997.
So upgrading got to version >= v10.1.0 and passing timeout, retry options to checkHttp function can resolve this issue.