Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docs about Electron support #1473

Closed
1 task done
Tracked by #1684
devjerry opened this issue Sep 21, 2020 · 0 comments
Closed
1 task done
Tracked by #1684

Improve docs about Electron support #1473

devjerry opened this issue Sep 21, 2020 · 0 comments
Labels
documentation The issue will improve the docs ✭ help wanted ✭

Comments

@devjerry
Copy link
Contributor

What would you like to discuss?

This section (and mainly the title) in readme.md is super confusing:

Electron support has been removed

The Electron net module is not consistent with the Node.js http module. See #899 for more info.

It implies that you should not use Got in Electron at all.

It took me quite a time to go thru the #899 and all other referenced issues and PRs when all I wanted to see is this piece of info:
#899 (comment)

I think that would be helpful to reword that section so devs that want to use Got in Electron wouldn't be discouraged.

Checklist

  • I have read the documentation.
@szmarczak szmarczak added documentation The issue will improve the docs ✭ help wanted ✭ labels Sep 22, 2020
@szmarczak szmarczak mentioned this issue Apr 11, 2021
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation The issue will improve the docs ✭ help wanted ✭
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devjerry @szmarczak