Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache silently fails on particular URL #1193

Closed
2 tasks done
privatenumber opened this issue Apr 27, 2020 · 4 comments
Closed
2 tasks done

Cache silently fails on particular URL #1193

privatenumber opened this issue Apr 27, 2020 · 4 comments
Labels
bug Something does not work as it should ✭ help wanted ✭

Comments

@privatenumber
Copy link

privatenumber commented Apr 27, 2020

Describe the bug

  • Node.js version: 12.16.2
  • OS & version: Mac

Actual behavior

Using got to hit the Vue endpoint on UNPKG fails silently.

Expected behavior

For it to not silently fail.

Code to reproduce

const got = require('got');

got('https://unpkg.com/[email protected]/dist/vue.js', {
	cache: new Map(), // Removing this fixes it
}).then(console.log);

Interestingly, other endpoints work fine:

got('https://unpkg.com/react', {
	cache: new Map(),
}).then(console.log);

Will be using v10.7.0 for now.

Checklist

  • I have read the documentation.
  • I have tried my code with the latest version of Node.js and Got.
@szmarczak
Copy link
Collaborator

Will be using v10.7.0 for now.

Are you saying that it works as expected on 10.7.0?

@privatenumber
Copy link
Author

Yep

@szmarczak szmarczak added bug Something does not work as it should ✭ help wanted ✭ labels Apr 27, 2020
@szmarczak szmarczak changed the title Silently fails on particular URL Cache silently fails on particular URL May 2, 2020
@szmarczak
Copy link
Collaborator

Found the bug

@privatenumber
Copy link
Author

Thanks @szmarczak !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as it should ✭ help wanted ✭
Projects
None yet
Development

No branches or pull requests

2 participants