Initialize globalResponse in case of ignored HTTPError

sindresorhus · Nov 30, 2020 · 6c9c612 · 6c9c612
1 parent 1107cc6
commit 6c9c612
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/source/as-promise/index.ts b/source/as-promise/index.ts
@@ -143,6 +143,7 @@ export default function asPromise<T>(normalizedOptions: NormalizedOptions): Canc
 
 				if (error instanceof HTTPError && !options.throwHttpErrors) {
 					const {response} = error;
+					globalResponse = response;
 					resolve(request.options.resolveBodyOnly ? response.body as T : response as unknown as T);
 					return;
 				}

diff --git a/test/promise.ts b/test/promise.ts
@@ -80,7 +80,7 @@ test('promise.json() can be called before a file stream body is open', withServe
 	await Promise.all(checks);
 });
 
-test.failing('promise.json() does not fail when server returns an error', withServer, async (t, server, got) => {
+test('promise.json() does not fail when server returns an error', withServer, async (t, server, got) => {
 	server.get('/', (_request, response) => {
 		response.statusCode = 400;
 		response.end('{}');