Require Node.js 16

Fixes #989
Fixes #1581

benchmark/index.ts

@@ -1,4 +1,3 @@
-import {URL} from 'node:url';
 import https from 'node:https';
 /// import axios from 'axios';
 import Benchmark from 'benchmark';

documentation/3-streams.md

@@ -27,29 +27,27 @@ This constructor takes the same arguments as the Got promise.
 > - If there's no body on purpose, remember to `stream.end()` or set the body option to an empty string.
 
 ```js
-import {promisify} from 'node:util';
 import stream from 'node:stream';
+import {pipeline as streamPipeline} from 'node:stream/promises';
 import fs from 'node:fs';
 import got from 'got';
 
-const pipeline = promisify(stream.pipeline);
-
 // This example streams the GET response of a URL to a file.
-await pipeline(
+await streamPipeline(
 	got.stream('https://sindresorhus.com'),
 	fs.createWriteStream('index.html')
 );
 
 // For POST, PUT, PATCH, and DELETE methods, `got.stream` returns a `stream.Writable`.
 // This example POSTs the contents of a file to a URL.
-await pipeline(
+await streamPipeline(
 	fs.createReadStream('index.html'),
 	got.stream.post('https://sindresorhus.com'),
 	new stream.PassThrough()
 );
 
 // In order to POST, PUT, PATCH, or DELETE without a request body, explicitly specify an empty body:
-await pipeline(
+await streamPipeline(
 	got.stream.post('https://sindresorhus.com', { body: '' }),
 	new stream.PassThrough()
 )
@@ -181,7 +179,7 @@ Whether the socket was used for other previous requests.
 This is emitted when a HTTP response is received.
 
 ```js
-import {pipeline} from 'node:stream/promises';
+import {pipeline as streamPipeline} from 'node:stream/promises';
 import {createWriteStream} from 'node:fs';
 import got from 'got';
 
@@ -202,7 +200,7 @@ readStream.on('response', async response => {
 	readStream.off('error', onError);
 
 	try {
-		await pipeline(
+		await streamPipeline(
 			readStream,
 			createWriteStream('image.png')
 		);

documentation/migration-guides/nodejs.md

@@ -78,10 +78,10 @@ Well, it's easy as that:
 
 ```js
 import got from 'got';
-import stream from 'node:stream';
+import {pipeline as streamPipeline} from 'node:stream/promises';
 import fs from 'node:fs';
 
-await stream.promises.pipeline(
+await streamPipeline(
 	fs.createReadStream('article.txt'),
 	got.stream.post('https://httpbin.org/anything'),
 	fs.createWriteStream('httpbin.txt')

documentation/migration-guides/request.md

@@ -113,15 +113,12 @@ http.createServer((serverRequest, serverResponse) => {
 The cool feature here is that Request can proxy headers with the stream, but Got can do that too!
 
 ```js
-import {promisify} from 'node:util';
-import stream from 'node:stream';
+import {pipeline as streamPipeline} from 'node:stream/promises';
 import got from 'got';
 
-const pipeline = promisify(stream.pipeline);
-
 const server = http.createServer(async (serverRequest, serverResponse) => {
 	if (serverRequest.url === '/doodle.png') {
-		await pipeline(
+		await streamPipeline(
 			got.stream('https://example.com/doodle.png'),
 			serverResponse
 		);

documentation/quick-start.md

@@ -65,7 +65,7 @@ The [Stream API](3-streams.md) allows to leverage [Node.js Streams](https://node
 
 ```js
 import fs from 'node:fs';
-import {pipeline} from 'node:stream/promises';
+import {pipeline as streamPipeline} from 'node:stream/promises';
 import got from 'got';
 
 const url = 'https://httpbin.org/anything';
@@ -81,7 +81,7 @@ const gotStream = got.stream.post(url, options);
 const outStream = fs.createWriteStream('anything.json');
 
 try {
-	await pipeline(gotStream, outStream);
+	await streamPipeline(gotStream, outStream);
 } catch (error) {
 	console.error(error);
 }

package.json

@@ -6,10 +6,12 @@
 	"repository": "sindresorhus/got",
 	"funding": "https://github.com/sindresorhus/got?sponsor=1",
 	"type": "module",
-	"exports": "./dist/source/index.js",
-	"types": "./dist/source/index.d.ts",
+	"exports": {
+		"types": "./dist/source/index.d.ts",
+		"default": "./dist/source/index.js"
+	},
 	"engines": {
-		"node": ">=14.16"
+		"node": ">=16"
 	},
 	"scripts": {
 		"test": "xo && tsc --noEmit && ava",
@@ -99,8 +101,8 @@
 		"tough-cookie": "4.1.2",
 		"ts-node": "^10.8.2",
 		"type-fest": "^3.6.1",
-		"typescript": "~4.9.5",
-		"xo": "^0.53.1"
+		"typescript": "^5.0.4",
+		"xo": "^0.54.2"
 	},
 	"sideEffects": false,
 	"ava": {
@@ -135,8 +137,6 @@
 		"rules": {
 			"@typescript-eslint/no-empty-function": "off",
 			"n/no-deprecated-api": "off",
-			"n/prefer-global/url": "off",
-			"n/prefer-global/url-search-params": "off",
 			"@typescript-eslint/no-implicit-any-catch": "off",
 			"unicorn/prefer-node-protocol": "off",
 			"ava/assertion-arguments": "off",
@@ -146,6 +146,8 @@
 			"@typescript-eslint/no-unsafe-call": "off",
 			"@typescript-eslint/await-thenable": "off",
 			"@typescript-eslint/no-redundant-type-constituents": "off",
+			"@typescript-eslint/no-unsafe-argument": "off",
+			"@typescript-eslint/promise-function-async": "off",
 			"no-lone-blocks": "off",
 			"unicorn/no-await-expression-member": "off"
 		}

source/core/index.ts

@@ -1,7 +1,6 @@
 import process from 'node:process';
 import {Buffer} from 'node:buffer';
 import {Duplex, type Readable} from 'node:stream';
-import {URL, URLSearchParams} from 'node:url';
 import http, {ServerResponse} from 'node:http';
 import type {ClientRequest, RequestOptions} from 'node:http';
 import type {Socket} from 'node:net';
@@ -46,6 +45,8 @@ import {
 	AbortError,
 } from './errors.js';
 
+const {buffer: getStreamAsBuffer} = getStream;
+
 type Error = NodeJS.ErrnoException;
 
 export type Progress = {
@@ -54,8 +55,6 @@ export type Progress = {
 	total?: number;
 };
 
-const {buffer: getBuffer} = getStream;
-
 const supportsBrotli = is.string(process.versions.brotli);
 
 const methodsWithoutBody: ReadonlySet<string> = new Set(['GET', 'HEAD']);
@@ -176,7 +175,7 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 	private _isFromCache?: boolean;
 	private _cannotHaveBody: boolean;
 	private _triggerRead: boolean;
-	declare private _jobs: Array<() => void>;
+	declare private readonly _jobs: Array<() => void>;
 	private _cancelTimeouts: () => void;
 	private readonly _removeListeners: () => void;
 	private _nativeResponse?: IncomingMessageWithTimings;
@@ -877,7 +876,11 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 
 		try {
 			// Errors are emitted via the `error` event
-			const rawBody = await getBuffer(from);
+			const rawBody = await getStreamAsBuffer(from);
+
+			// TODO: Switch to this:
+			// let rawBody = await from.toArray();
+			// rawBody = Buffer.concat(rawBody);
 
 			// On retry Request is destroyed with no error, therefore the above will successfully resolve.
 			// So in order to check if this was really successfull, we need to check if it has been properly ended.
@@ -992,7 +995,6 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 						// We only need to implement the error handler in order to support HTTP2 caching.
 						// The result will be a promise anyway.
 						// @ts-expect-error ignore
-						// eslint-disable-next-line @typescript-eslint/promise-function-async
 						result.once = (event: string, handler: (reason: unknown) => void) => {
 							if (event === 'error') {
 								(async () => {

source/core/options.ts

@@ -1,7 +1,6 @@
 import process from 'node:process';
 import type {Buffer} from 'node:buffer';
 import {promisify, inspect} from 'node:util';
-import {URL, URLSearchParams} from 'node:url';
 import {checkServerIdentity} from 'node:tls';
 // DO NOT use destructuring for `https.request` and `http.request` as it's not compatible with `nock`.
 import http from 'node:http';
@@ -976,7 +975,7 @@ const init = (options: OptionsInit, withOptions: OptionsInit, self: Options): vo
 
 export default class Options {
 	private _unixOptions?: NativeRequestOptions;
-	private _internals: InternalsType;
+	private readonly _internals: InternalsType;
 	private _merging: boolean;
 	private readonly _init: OptionsInit[];
 

source/core/response.ts

@@ -1,5 +1,4 @@
 import type {Buffer} from 'node:buffer';
-import type {URL} from 'node:url';
 import type {IncomingMessageWithTimings, Timings} from '@szmarczak/http-timer';
 import {RequestError} from './errors.js';
 import type {ParseJsonFunction, ResponseType} from './options.js';

source/core/timed-out.ts

@@ -90,15 +90,15 @@ export default function timedOut(request: ClientRequest, delays: Delays, options
 		}
 	});
 
-	if (typeof delays.request !== 'undefined') {
+	if (delays.request !== undefined) {
 		const cancelTimeout = addTimeout(delays.request, timeoutHandler, 'request');
 
 		once(request, 'response', (response: IncomingMessage): void => {
 			once(response, 'end', cancelTimeout);
 		});
 	}
 
-	if (typeof delays.socket !== 'undefined') {
+	if (delays.socket !== undefined) {
 		const {socket} = delays;
 
 		const socketTimeoutHandler = (): void => {
@@ -115,10 +115,10 @@ export default function timedOut(request: ClientRequest, delays: Delays, options
 		});
 	}
 
-	const hasLookup = typeof delays.lookup !== 'undefined';
-	const hasConnect = typeof delays.connect !== 'undefined';
-	const hasSecureConnect = typeof delays.secureConnect !== 'undefined';
-	const hasSend = typeof delays.send !== 'undefined';
+	const hasLookup = delays.lookup !== undefined;
+	const hasConnect = delays.connect !== undefined;
+	const hasSecureConnect = delays.secureConnect !== undefined;
+	const hasSend = delays.send !== undefined;
 	if (hasLookup || hasConnect || hasSecureConnect || hasSend) {
 		once(request, 'socket', (socket: net.Socket): void => {
 			const {socketPath} = request as ClientRequest & {socketPath?: string};
@@ -127,7 +127,7 @@ export default function timedOut(request: ClientRequest, delays: Delays, options
 			if (socket.connecting) {
 				const hasPath = Boolean(socketPath ?? net.isIP(hostname ?? host ?? '') !== 0);
 
-				if (hasLookup && !hasPath && typeof (socket.address() as net.AddressInfo).address === 'undefined') {
+				if (hasLookup && !hasPath && (socket.address() as net.AddressInfo).address === undefined) {
 					const cancelTimeout = addTimeout(delays.lookup!, timeoutHandler, 'lookup');
 					once(socket, 'lookup', cancelTimeout);
 				}
@@ -168,14 +168,14 @@ export default function timedOut(request: ClientRequest, delays: Delays, options
 		});
 	}
 
-	if (typeof delays.response !== 'undefined') {
+	if (delays.response !== undefined) {
 		once(request, 'upload-complete', (): void => {
 			const cancelTimeout = addTimeout(delays.response!, timeoutHandler, 'response');
 			once(request, 'response', cancelTimeout);
 		});
 	}
 
-	if (typeof delays.read !== 'undefined') {
+	if (delays.read !== undefined) {
 		once(request, 'response', (response: IncomingMessage): void => {
 			const cancelTimeout = addTimeout(delays.read!, timeoutHandler, 'read');
 			once(response, 'end', cancelTimeout);

source/core/utils/is-unix-socket-url.ts

@@ -1,5 +1,3 @@
-import type {URL} from 'url';
-
 // eslint-disable-next-line @typescript-eslint/naming-convention
 export default function isUnixSocketURL(url: URL) {
 	return url.protocol === 'unix:' || url.hostname === 'unix';

source/core/utils/options-to-url.ts

@@ -1,6 +1,3 @@
-/* istanbul ignore file: deprecated */
-import {URL} from 'node:url';
-
 // eslint-disable-next-line @typescript-eslint/naming-convention
 export type URLOptions = {
 	href?: string;

source/core/utils/url-to-options.ts

@@ -1,4 +1,4 @@
-import type {URL, UrlWithStringQuery} from 'node:url';
+import type {UrlWithStringQuery} from 'node:url';
 import is from '@sindresorhus/is';
 
 // TODO: Deprecate legacy URL at some point

source/create.ts

@@ -1,4 +1,3 @@
-import type {URL} from 'node:url';
 import is, {assert} from '@sindresorhus/is';
 import asPromise from './as-promise/index.js';
 import type {

source/types.ts

@@ -1,5 +1,4 @@
 import type {Buffer} from 'node:buffer';
-import type {URL} from 'node:url';
 import type {CancelableRequest} from './as-promise/types.js';
 import type {Response} from './core/response.js';
 import type Options from './core/options.js';