-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4 to v5 Update Functionality Differences #34
Comments
// @stroncium |
By design this library doesn't guarantee that it won't give the same result to parallel calls.
... works all the same for another part of the same application, which might find the same port(equals starts using then stops using it) before you start to actually use it. The change in behavior might be related to switch to async which is supposed to slightly change distribution of code execution between ticks. However, I can't be entirely sure this is the cause in your case and what is actually happening. Need better reproduction steps. |
Duplicate of #23 |
The in-process race condition you're experiencing was fixed by 73e21d8. |
I may need some guidance as to how to go about nailing down the cause. I'm using
getPort
in anava
test environment in conjunction withpuppeteer
andwebpack
. When using [email protected] everything works as expected. After updating to v5, I get multiple test files attempting to use the same port. My only shot-in-the-dark is that it's somehow related to the changes in v5 to the available port code.Fwiw, my calls to
getPort
are relatively simple:getPort({ port: 55555 });
The text was updated successfully, but these errors were encountered: