avro file type support added #597
Conversation
core.d.ts
Outdated
| @@ -167,6 +168,7 @@ export type MimeType = | |||
| | 'image/vnd.ms-photo' | |||
| | 'image/vnd.adobe.photoshop' | |||
| | 'application/x-indesign' | |||
| | 'application/avro' | |||
There was a problem hiding this comment.
Should be added to the end.
core.d.ts
Outdated
| @@ -2,6 +2,7 @@ import type {Readable as ReadableStream} from 'node:stream'; | |||
| import type {ITokenizer} from 'strtok3'; | |||
|
|
|||
| export type FileExtension = | |||
| | 'avro' | |||
There was a problem hiding this comment.
Should be added to the end.
core.js
Outdated
| @@ -292,6 +299,13 @@ class FileTypeParser { | |||
| }; | |||
| } | |||
|
|
|||
| if (this.checkString('avro')) { | |||
There was a problem hiding this comment.
Can you link to a source for this?
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't see it written anywhere there that the file header must start with avro.
There was a problem hiding this comment.
After further research I think you are correct, it is not specified anywhere that the file header MUST end with avro.
I have removed that check.
There was a problem hiding this comment.
I've also noticed people use .avsc and .acme, but I don't quite understand the difference
supported.js
Outdated
| @@ -1,4 +1,5 @@ | |||
| export const extensions = [ | |||
| 'avro', | |||
There was a problem hiding this comment.
It was implied that #597 (comment) applied here too. And the below.
Avro file type support added, steps in contributing.md file followed.