Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor stdio option for execa.node() #303

Merged
merged 5 commits into from
Jun 19, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Jun 19, 2019

This is a refactoring of the stdio option handling for execa.node().

It also fixes one bug: undefined descriptors beyond the first three were converted to pipe. Those should be kept as undefined instead. See Node.js documentation:

null, undefined - Use default value. For stdio fds 0, 1, and 2 (in other words, stdin, stdout, and stderr) a pipe is created. For fd 3 and up, the default is 'ignore'.

This does not change behavior otherwise.

Some code comments and tests are added too.

@GMartigny

@sindresorhus sindresorhus merged commit 825f8a7 into master Jun 19, 2019
@sindresorhus sindresorhus deleted the chore/refactor-stdio-node branch June 19, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants