Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /q option to cmd as well as cmd.exe on Windows #203

Merged
merged 5 commits into from
Apr 16, 2019
Merged

Add /q option to cmd as well as cmd.exe on Windows #203

merged 5 commits into from
Apr 16, 2019

Conversation

GMartigny
Copy link
Contributor

The /q option should be added whether the running command is cmd.exe or cmd.

ehmicky
ehmicky reviewed Apr 8, 2019
View reviewed changes
index.js Outdated Show resolved Hide resolved
@ehmicky ehmicky self-requested a review April 8, 2019 13:28
ehmicky
ehmicky requested changes Apr 8, 2019
View reviewed changes
Copy link
Collaborator

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

Maybe only adding .exe to path.basename() might do the trick?

Also adding a test for it would be a good idea so we make sure this works in the future.

@sindresorhus
Copy link
Owner

Can you give the PR a more descriptive title?

@GMartigny GMartigny changed the title Windows /q option Add /q option to cmd as well as cmd.exe on Windows Apr 12, 2019
@ehmicky
Copy link
Collaborator

ehmicky commented Apr 12, 2019

This looks good to me. Thanks for this PR!

@ehmicky ehmicky requested a review from sindresorhus April 12, 2019 22:04
@sindresorhus sindresorhus changed the title Add /q option to cmd as well as cmd.exe on Windows Add /q option to cmd as well as cmd.exe on Windows Apr 16, 2019
@sindresorhus sindresorhus merged commit 10c73dc into sindresorhus:master Apr 16, 2019
@GMartigny GMartigny deleted the windowsOptions branch April 16, 2019 18:39
@ehmicky ehmicky mentioned this pull request May 15, 2019
Closed
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GMartigny @sindresorhus @ehmicky