Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename .cmd to .command #194

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Rename .cmd to .command #194

merged 1 commit into from
Mar 25, 2019

Conversation

satyarohith
Copy link
Contributor

closes #190

@satyarohith satyarohith changed the title Rename .cmd to .command Rename .cmd to .command Mar 20, 2019
ehmicky
ehmicky requested changes Mar 20, 2019
View reviewed changes
Copy link
Collaborator

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Two missing things your forgot though:

  • the cmd property returned by execa.sync() (end of index.js file)
  • the cmd property is shown in two examples on the README.md

@satyarohith
Copy link
Contributor Author

Thanks for your kindness! Updated!

@ehmicky
Copy link
Collaborator

ehmicky commented Mar 20, 2019

Looks good to me, thanks for this PR! 🎉

Waiting for review from @sindresorhus before merging.

@ehmicky ehmicky requested a review from sindresorhus March 20, 2019 16:50
@sindresorhus
Copy link
Owner

Can you also update https://github.com/sindresorhus/execa/blob/master/index.d.ts and https://github.com/sindresorhus/execa/blob/master/index.test-d.ts?

@satyarohith
Copy link
Contributor Author

@sindresorhus Updated! 🎉

@sindresorhus sindresorhus merged commit 95c8a14 into sindresorhus:master Mar 25, 2019
@sindresorhus
Copy link
Owner

Looks great :)

@satyarohith satyarohith deleted the rename branch March 25, 2019 03:45
@ehmicky ehmicky mentioned this pull request May 15, 2019
Closed
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

@sindresorhus sindresorhus Awaiting requested review from sindresorhus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename . cmd to .command
3 participants
@satyarohith @ehmicky @sindresorhus