Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo #1153

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Fix a typo #1153

merged 2 commits into from
Sep 7, 2024

Conversation

rrthomas
Copy link
Contributor

@rrthomas rrthomas commented Sep 6, 2024 •
edited by ehmicky
Loading

Fixes #1152.

rrthomas
rrthomas commented Sep 6, 2024
View reviewed changes
Copy link
Contributor Author

@rrthomas rrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A one-character fix.

ehmicky
ehmicky reviewed Sep 7, 2024
View reviewed changes
docs/api.md Outdated Show resolved Hide resolved
@ehmicky
Copy link
Collaborator

ehmicky commented Sep 7, 2024

Thanks @rrthomas. Just a small issue.

@ehmicky ehmicky merged commit 3fc8049 into sindresorhus:main Sep 7, 2024
6 checks passed
@rrthomas
Copy link
Contributor Author

rrthomas commented Sep 7, 2024

Thanks, I didn't spot that the \ was correct, not a typo, and the close paren was simply missing. This is the sort of issue where I think it's probably better for the upstream maintainers to take two minutes to fix a bug rather than 5 minutes to interact with the reporter. My perspective is that I'm using execa as part of other libre projects, and I think we'll all have more fun and give more to the world if we spend our time on our own projects in this case. I understand of course that the one thing we all lack is compensation and/or assistance, and also that execa and other projects you work on are wildly popular, unlike the projects I work on, so the load on your may well be correspondingly greater.

@WontonSam WontonSam mentioned this pull request Oct 7, 2024
Open
@tunnckoCore tunnckoCore mentioned this pull request Oct 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmicky ehmicky ehmicky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation markup problem in execa/docs/api.md
2 participants
@rrthomas @ehmicky