-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unref error #400
Fix unref error #400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR @mifi! 🎉
This looks good to me (except for one small detail)!
Co-Authored-By: ehmicky <[email protected]>
Waiting for @sindresorhus to review it as well. |
Would be good to open an issue on Electron about this and add a code comment that links to that issue. |
@sindresorhus Would it be ready to merge otherwise? |
Yes, I just like to give context to workarounds and ensure it will be fixed upstream eventually. |
}, timeout); | ||
|
||
// istanbul ignore else | ||
if (t.unref) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ehmicky This still needs a code comment about why it's guarded. For example:
Guarded because there's no
.unref
whenexeca
is used in the renderer process in Electron.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I thought this was ok to merge, sorry about that.
I've added the comment in #401.
Is it possible to backport this fix to |
See #399