Make stdout and stderr empty strings with execa.sync() on errors

sindresorhus · May 14, 2019 · ace8ef2 · ace8ef2
1 parent c7d42b7
commit ace8ef2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/index.js b/index.js
@@ -109,9 +109,10 @@ function handleInput(spawned, input) {
 	}
 }
 
-function handleOutput(options, value) {
+function handleOutput(options, value, error) {
 	if (typeof value !== 'string' && !Buffer.isBuffer(value)) {
-		return;
+		// When `execa.sync()` errors, we normalize it to '' to mimic `execa()`
+		return error === undefined ? undefined : '';
 	}
 
 	if (options.stripFinalNewline) {
@@ -427,8 +428,8 @@ module.exports.sync = (command, args, options) => {
 	}
 
 	const result = childProcess.spawnSync(parsed.command, parsed.args, parsed.options);
-	result.stdout = handleOutput(parsed.options, result.stdout);
-	result.stderr = handleOutput(parsed.options, result.stderr);
+	result.stdout = handleOutput(parsed.options, result.stdout, result.error);
+	result.stderr = handleOutput(parsed.options, result.stderr, result.error);
 
 	if (result.error || result.status !== 0 || result.signal !== null) {
 		const error = makeError(result, {

diff --git a/readme.md b/readme.md
@@ -107,6 +107,8 @@ try {
 		command: 'wrong command',
 		exitCode: 2,
 		exitCodeName: 'ENOENT',
+		stdout: '',
+		stderr: '',
 		failed: true,
 		timedOut: false,
 		isCanceled: false,