Improve error messages when an error event is emitted (#269)

sindresorhus · May 30, 2019 · 2307d95 · 2307d95
1 parent 3b103f8
commit 2307d95
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -198,7 +198,11 @@ function getErrorPrefix({timedOut, timeout, signal, exitCodeName, exitCode, isCa
 		return `was killed with ${signal}`;
 	}
 
-	return `failed with exit code ${exitCode} (${exitCodeName})`;
+	if (exitCode !== undefined) {
+		return `failed with exit code ${exitCode} (${exitCodeName})`;
+	}
+
+	return 'failed';
 }
 
 function joinCommand(file, args = []) {

diff --git a/test.js b/test.js
@@ -194,6 +194,12 @@ test('input option can be a Buffer - sync', t => {
 	t.is(stdout, 'testing12');
 });
 
+test('child process errors are handled', async t => {
+	const child = execa('noop');
+	child.emit('error', new Error('test'));
+	await t.throwsAsync(child, /Command failed.*\ntest/);
+});
+
 test('opts.stdout:ignore - stdout will not collect data', async t => {
 	const {stdout} = await execa('stdin', {
 		input: 'hello',