-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript error for glob types in v4 #83
Comments
Is this still a problem with v4.1.0? Ensure you use it like done here: https://github.com/sindresorhus/del/blob/master/index.test-d.ts |
@sindresorhus yes, this also exists in 4.1.0 It happens because glob options are imported here, but glob itself doesn't have types inside, they have to be installed separately using In v3, types were installed using So, I can think of 2 ways of solving this:
I had same issue and conclusion after trying to add types to one of my packages. Chose 2-nd way since it doesn't add unnecessary type packages for non-TS devs. I guess, this is one of the reasons why Hope this makes sense :) |
Thanks for elaborating :) |
Ups, my bad! |
@BendingBender No worries. I missed it too. |
Hey,
Since v4 has types file inside, there is no
glob
types which is used inside.When using v4 typescript gives you an error about this missing types. v3 had external types which installed
glob
types automatically and didn't give you an error.The text was updated successfully, but these errors were encountered: