Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bumping globby. #63

Closed
wtgtybhertgeghgtwtg opened this issue Dec 3, 2017 · 4 comments · Fixed by #64
Closed

Consider bumping globby. #63

wtgtybhertgeghgtwtg opened this issue Dec 3, 2017 · 4 comments · Fixed by #64

Comments

@wtgtybhertgeghgtwtg
Copy link

globby@7 comes with two new options: expandDirectories and gitignore. It would be nice to be able to use those from del. One potential problem I see with this proposal is that globby@7 now has nodir default to true, which may not be what is expected in the use cases for del.

@odarbelaeze
Copy link

Was about to do the same 👍

@alexander-akait
Copy link

/cc @sindresorhus can we bump globby to latest?

@sindresorhus
Copy link
Owner

sindresorhus commented Apr 23, 2018

@evilebottnawi If prefer not to do that yet. Globby 8 still has many regressions because of the switch to fast-glob: https://github.com/sindresorhus/globby/issues

@realityking
Copy link
Contributor

@sindresorhus If globby 8 is blocked for a while, would you consider an update to 7.1.1 (essentially 98dd4b6)? While the changes are not massive, it eliminates a lot of dependencies which would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants