Expose preserveConsecutiveUppercase option #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Sep 28, 2023
| @@ -27,6 +27,9 @@ camelcaseKeys({'foo-bar': true, nested: {unicorn_rainbow: true}}, {deep: true}); | |||
| camelcaseKeys({a_b: 1, a_c: {c_d: 1, c_e: {e_f: 1}}}, {deep: true, stopPaths: ['a_c.c_e']}), | |||
| //=> {aB: 1, aC: {cD: 1, cE: {e_f: 1}}} | |||
|
|
|||
| camelcaseKeys({'foo-BAR': true, nested: {unicorn_RAINbow: true}}, {deep: true, preserveConsecutiveUppercase: true}); | |||
| //=> {fooBAR: true, nested: {unicornRAINbow: true}} | |||
There was a problem hiding this comment.
This should be on line 125, together with the docs for it.
There was a problem hiding this comment.
I kept the way it was made for the other options. At the moment it is not the case for all the option. It is also consistent with your other related packages (i.e. camelcase README).
=> Is it ok to keep it like this at the moment? I've added an example with the value = false as well.
If yes, I'll you resolve it :)
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sindresorhus,
Thanks for your great work. It is very useful in my current project.
Based on #88 request, I added the preserveConsecutiveUppercase option.
I updated the following elements :
I proposed a bump to the version 10.0.0 based on your versioning strategy.
Fixes #88