Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite neighbor list code and other pieces so that there are no handles to internal data #15

Open
obrienpja opened this issue Dec 27, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@obrienpja
Copy link
Member

Item 28 in Scott Meyers' Effective C++ says that C++ programmers should not return handles to object internals. I am currently using handles in this project, and I must remove them. The design I have implemented indeed feels wrong. I should try to rewrite this code in the way Scott describes in Item 28, and I should probably make sure the new design has the appropriate setters.

@obrienpja obrienpja self-assigned this Dec 27, 2018
@obrienpja obrienpja added the enhancement New feature or request label Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant