Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark query parameters as optional #114

Closed
Jameskmonger opened this issue Sep 4, 2018 · 3 comments
Closed

Mark query parameters as optional #114

Jameskmonger opened this issue Sep 4, 2018 · 3 comments
Assignees

Comments

@Jameskmonger
Copy link
Contributor

requestGenerator in index.ts has an optional parameter data:

return function(method: string, uri: string, data: any = {}) {

However, places that use this, for example projectAssignments.me do not mark this parameter as optional:

public me(query: PagenationParameters) {

An obvious workaround is to do me({}), but it would be good to be able to just call me() and let the package handle the defaults

@simplyspoke
Copy link
Owner

I agree,

Should have some time this evening for a update.

Thanks for all the help and feedback on the module!

@simplyspoke
Copy link
Owner

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Jameskmonger
Copy link
Contributor Author

Thanks @simplyspoke 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants