Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query target repository before deploying #8

Closed
mosabua opened this issue Oct 29, 2014 · 7 comments
Closed

Query target repository before deploying #8

mosabua opened this issue Oct 29, 2014 · 7 comments
Assignees

Comments

@mosabua
Copy link
Member

mosabua commented Oct 29, 2014

or for starters just log that deployment failed and continue

@mosabua
Copy link
Member Author

mosabua commented Jan 29, 2015

Log and continue already works but its has ugly stack traces... need to clean this up.

@mosabua
Copy link
Member Author

mosabua commented Jan 29, 2015

This is cleaned up now in terms of the log. But we are still doing duplicate deployments (overwrites) or we fail after trying. It would be faster to query target repo .. but that will depend on what runs there.. so is more complex than the brute force...

@mosabua
Copy link
Member Author

mosabua commented Feb 3, 2015

According to Igor we can still use the Aether ArtifactResolver ... just specify only the target repo. You could also ask for the metadata for all available vrsions .. but that only works if the remote is trustworthy in the sense that it provides the right info. Also that might not matter in our case. It might however still resolve the artifact (as in fully download it... and that would be bad..).

@mosabua
Copy link
Member Author

mosabua commented Feb 3, 2015

So maybe we still have to assemble the remote path and do a plain http request for it and abandon retrieval once download starts to avoid the time cost of a download..

@mosabua
Copy link
Member Author

mosabua commented Mar 5, 2015

Might not even be worth the time, especially if the files that are deployed are not big. They are uploaded first and then it fails... so for bigger files it should probably be done.

@mosabua mosabua self-assigned this Mar 5, 2015
@mosabua
Copy link
Member Author

mosabua commented Aug 12, 2015

In progress..

@mosabua
Copy link
Member Author

mosabua commented Aug 12, 2015

Pushed to master

@mosabua mosabua closed this as completed Aug 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant