From 5950fbdede249fb5c56c4f145daa9ebfc322b188 Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Wed, 21 Sep 2022 15:22:25 +0000 Subject: [PATCH] vuln-fix: Partial Path Traversal Vulnerability This fixes a partial path traversal vulnerability. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`. To demonstrate this vulnerability, consider `"/usr/outnot".startsWith("/usr/out")`. The check is bypassed although `/outnot` is not under the `/out` directory. It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object. For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`; however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`. Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal') Severity: Medium CVSSS: 6.1 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.PartialPathTraversalVulnerability) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/13 Co-authored-by: Moderne --- .../maven/plugins/android/phase09package/ApklibMojo.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/com/simpligility/maven/plugins/android/phase09package/ApklibMojo.java b/src/main/java/com/simpligility/maven/plugins/android/phase09package/ApklibMojo.java index fb10b639e..7cd7417e6 100644 --- a/src/main/java/com/simpligility/maven/plugins/android/phase09package/ApklibMojo.java +++ b/src/main/java/com/simpligility/maven/plugins/android/phase09package/ApklibMojo.java @@ -258,10 +258,9 @@ protected void addJavaResource( JarArchiver jarArchiver, Resource javaResource, final File javaResourceDirectory = new File( javaResource.getDirectory() ); if ( javaResourceDirectory.exists() ) { - final String resourcePath = javaResourceDirectory.getCanonicalPath(); final String apkLibUnpackBasePath = getUnpackedLibsDirectory().getCanonicalPath(); // Don't include our dependencies' resource dirs. - if ( ! resourcePath.startsWith( apkLibUnpackBasePath ) ) + if ( ! javaResourceDirectory.getCanonicalFile().toPath().startsWith(apkLibUnpackBasePath) ) { final DefaultFileSet javaResourceFileSet = new DefaultFileSet(); javaResourceFileSet.setDirectory( javaResourceDirectory );