Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency with url vs urlpath #54

Closed
stefanoborini opened this issue Jul 6, 2016 · 4 comments
Closed

Consistency with url vs urlpath #54

stefanoborini opened this issue Jul 6, 2016 · 4 comments
Assignees
Milestone

Comments

@stefanoborini
Copy link
Contributor

There's a general inconsistency in "url" vs "urlpath" that makes things harder to understand.

  • a url is according to scheme:[//[user:password@]host[:port]][/]path[?query][#fragment], meaning that http://host:8000/foo/bar is a url. /foo/bar is not.
  • a urlpath is a path that goes into a url. We want this distinction because some paths are on the physical machine instead, so just saying path does not convey the appropriate context.

This inconsistency is inherited from jupyterhub, but now that we have control of the spawner and we pass what we want at the command line, we should be clear on the intent to avoid confusion.

@itziakos
Copy link
Member

is this fixed now?

@stefanoborini
Copy link
Contributor Author

@itziakos Partially, I fear. The merged solution fixes the option, but internally I am not sure we are consistent everywhere.

@kitchoi
Copy link
Contributor

kitchoi commented Jul 15, 2016

@sbo @itziakos shall we close this and open new issue when we spot missed loners? I don't guarantee I cleaned up all of them, but I tried my best.

@itziakos
Copy link
Member

Yes it is fine to open new issues on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants