Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomeHandler should not 'finish' in View and Stop but raise #106

Closed
kitchoi opened this issue Jul 15, 2016 · 1 comment
Closed

HomeHandler should not 'finish' in View and Stop but raise #106

kitchoi opened this issue Jul 15, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@kitchoi
Copy link
Contributor

kitchoi commented Jul 15, 2016

Let view and stop raise and then the HomeHandler.post will handle the logging.

self.finish("Unable to view the application")

self.finish("Unable to view the application")

@itziakos itziakos added the bug label Jul 15, 2016
@itziakos
Copy link
Member

Yes, I think it makes sense to make this change. Thanks @kitchoi

@itziakos itziakos added this to the 0.5.0 milestone Jul 15, 2016
@stefanoborini stefanoborini self-assigned this Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants