Confirm if this works with repos with branches in the history

[simonw]

I couldn't get this to work, and I have a hunch it may be because that repository uses branches and doesn't have a linear history:

git-history file iam.db \
  policy_sentry/shared/data/iam-definition.json \
  --id service --id privilege \
  --convert '
data = json.loads(content)
for service, stuff in data.items():
    for _, privilege in stuff["privileges"].items():
        privilege["service"] = service
        yield privilege
' --branch master

Against https://github.com/salesforce/policy_sentry

Originally posted by @simonw in simonw/iam-definitions-datasette#1 (comment)

[simonw]

Visualization of the branches over time: https://github.com/salesforce/policy_sentry/network

[simonw]

I'm suspicious that this code isn't iterating across every commit:

git-history/git_history/cli.py

Lines 15 to 16 in 1a2b0b8

	repo = git.Repo(repo_path, odbt=git.GitDB)
	commits = reversed(list(repo.iter_commits(ref, paths=[relative_path])))

I added some debug logging and I couldn't see it visit any commits which included versions of the policy_sentry/shared/data/iam-definition.json file.