Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "export all to csv/tsv" button available on saved dashboards to users with execute_sql permission #133

Open
toolness opened this issue Jun 22, 2021 · 3 comments · May be fixed by #144
Open

Make "export all to csv/tsv" button available on saved dashboards to users with execute_sql permission #133

toolness opened this issue Jun 22, 2021 · 3 comments · May be fixed by #144
Labels
enhancement New feature or request question Further information is requested

Comments

@toolness
Copy link
Contributor

It looks like this button, which was added in #50, might only be available on unsaved dashboards? Either that or I'm somehow not seeing it on the saved dashboard page...
@simonw
Copy link
Owner

simonw commented Jul 1, 2021

This is deliberate, because the "export all" operation is potentially quite expensive - I don't want to accidentally open that up to anyone on a public dashboard, since that could potentially be used for a denial of service attack.

@simonw simonw added the question Further information is requested label Jul 1, 2021
@simonw
Copy link
Owner

simonw commented Jul 1, 2021

It is however a frustrating limitation - maybe the answer here is to enable it on saved dashboards but only for users who have the execute_sql permission.

@simonw simonw added the enhancement New feature or request label Jul 1, 2021
@simonw simonw changed the title Saved dashboards don't seem to have an "export all to csv/tsv" button Make "export all to csv/tsv" button available on saved dashboards to users with execute_sql permission Jul 1, 2021
@drkane drkane mentioned this issue Jul 7, 2021
Open
@toolness
Copy link
Contributor Author

toolness commented Aug 5, 2021

Er, so yeah, in practice this has definitely been a frustrating limitation, since almost all of our use cases for the dashboard are for generating long lists of results to be exported as CSV. Mind if I issue a PR that does what you proposed above (enabling "export all as CSV" but only for users who have the execute_sql permission)?

This was referenced Aug 6, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
2 participants
@simonw @toolness