Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when hashed urls are turned on, the _memory db has improperly long-lived cache expiry #1581

Closed
fgregg opened this issue Dec 28, 2021 · 1 comment

Comments

@fgregg
Copy link
Contributor

fgregg commented Dec 28, 2021

if hashed_urls are on, then a -000 suffix is added to the _memory database, and the cache settings are set just as if it was a normal hashed database.

in particular, this header is set:

cache-control: max-age=31536000

this is not appropriate because the _memory-000 database isn't really hashed based on the contents of the databases (see #1561).

Either the cache-control header should be changed, or the _memory db should have a hash suffix that does depend on the contents of the databases.

@fgregg
Copy link
Contributor Author

fgregg commented Mar 24, 2022

this has been addressed by the datasette-hashed-urls plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant